Skip to content

More Various Fixes#314

Merged
florianhartung merged 11 commits intomainfrom
dev/various-fixes
Feb 16, 2026
Merged

More Various Fixes#314
florianhartung merged 11 commits intomainfrom
dev/various-fixes

Conversation

@florianhartung
Copy link
Copy Markdown
Collaborator

@florianhartung florianhartung commented Feb 5, 2026

Checks

  • Using Nix
    • Ran nix fmt
    • Ran nix flake check '.?submodules=1'
  • Using Rust tooling
    • Ran cargo fmt
    • Ran cargo test
    • Ran cargo check
    • Ran cargo build
    • Ran cargo doc

@florianhartung florianhartung mentioned this pull request Feb 5, 2026
Merged
7 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 6, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 87.50000% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/core/error.rs 0.00% 4 Missing ⚠️
src/validation/mod.rs 89.18% 4 Missing ⚠️
src/core/reader/types/export.rs 80.00% 2 Missing ⚠️
src/execution/interpreter_loop.rs 92.30% 1 Missing and 1 partial ⚠️
src/execution/store/mod.rs 92.85% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/core/reader/mod.rs 98.89% <ø> (ø)
src/core/reader/types/import.rs 90.32% <100.00%> (ø)
src/core/reader/types/mod.rs 90.38% <ø> (ø)
src/core/reader/types/values.rs 73.83% <100.00%> (+0.22%) ⬆️
src/core/slotmap.rs 82.55% <ø> (ø)
src/execution/config.rs 81.25% <100.00%> (ø)
src/execution/resumable.rs 100.00% <100.00%> (ø)
src/execution/store/instances.rs 84.90% <100.00%> (ø)
src/lib.rs 100.00% <ø> (ø)
src/execution/store/mod.rs 86.75% <92.85%> (+0.58%) ⬆️
... and 4 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@florianhartung florianhartung force-pushed the dev/various-fixes branch 2 times, most recently from 9cf247f to ffb78f7 Compare February 11, 2026 15:00
@cemonem
Copy link
Copy Markdown
Contributor

cemonem commented Feb 11, 2026

I have a hunch having a str ref from the bytecode in the exports might be trouble in the future, but can't offer a counter scenario. lgtm.

cemonem
cemonem previously approved these changes Feb 11, 2026
View reviewed changes
@florianhartung
feat(validation): error on too many funcs,tables,mems,globals
cc77db8 
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
@florianhartung
fix(core): remove unused ExportDesc methods
accec08 
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
@florianhartung
fix: don't export ExportDesc
f307615 
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
@florianhartung
refactor(core): rename ExportDesc variants
8b009d9 
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
@florianhartung
refactor: remove unnecessarily allowed unused/dead_code lints
d43b45a 
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
@florianhartung
fix: make (elem|data).drop operations infallible
ec7fdbc 
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
@florianhartung
refactor(execution): make FuncInst::ty non-cloning
171ba57 
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
@florianhartung
fix(execution): remove double lookup in call instructions
6e59e87 
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
@florianhartung
fix: borrow import names from bytecode instead of allocating them
5f39e1f 
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
@florianhartung
fix: borrow export name from bytecode instead of allocating it
64104ea 
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
@florianhartung
chore: apply clippy lints
3944c98 
Signed-off-by: Florian Hartung <florian.hartung@dlr.de>
@florianhartung florianhartung added this pull request to the merge queue Feb 16, 2026
Merged via the queue into main with commit c5d5f79 Feb 16, 2026
13 checks passed
@florianhartung florianhartung deleted the dev/various-fixes branch February 16, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cemonem cemonem cemonem approved these changes

@wucke13 wucke13 Awaiting requested review from wucke13

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@florianhartung @cemonem